Skip to content

Conversation

@silverwind
Copy link
Member

@silverwind silverwind commented Feb 1, 2026

We've been cutting down on the "striped" tables (where rows are using alternate row background colors). This completely removes them as I think such a design looks outdated.

The removal of selectors starting with .ui[class*="very basic"].table:not(.striped) is needed because of a specificity issue in the CSS where table cells would otherwise render with incorrect padding.

Example of one affected table:

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 1, 2026
@github-actions github-actions bot added modifies/templates This PR modifies the template files modifies/frontend labels Feb 1, 2026
@silverwind silverwind requested a review from Copilot February 1, 2026 10:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the outdated "striped" table design from the UI by eliminating the striped class from all table elements and removing associated CSS rules. The PR also fixes a CSS specificity issue where table cells were rendering with incorrect padding due to :not(.striped) selectors.

Changes:

  • Removed all striped class references from 16 template files
  • Removed CSS rules for striped table styling in web_src/css/modules/table.css and web_src/css/repo.css
  • Removed CSS specificity workaround rules (:not(.striped) selectors) to fix table cell padding issues

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.

Show a summary per file
File Description
web_src/css/repo.css Removed repository-specific striped table background color rule for commits table
web_src/css/modules/table.css Removed striped table styling rules and CSS specificity workaround rules with :not(.striped) selectors
templates/shared/actions/runner_list.tmpl Removed striped class from runner list table
templates/shared/actions/runner_edit.tmpl Removed striped class from runner task list table
templates/repo/commits_list.tmpl Removed striped class from commits table
templates/repo/branch/list.tmpl Removed striped class from both default branch and branches list tables
templates/package/shared/cleanup_rules/preview.tmpl Removed striped class from cleanup rules preview table
templates/admin/user/list.tmpl Removed striped class from user list table
templates/admin/stats.tmpl Removed striped class from statistics table
templates/admin/repo/list.tmpl Removed striped class from repository list table
templates/admin/queue_manage.tmpl Removed striped class from queue management table
templates/admin/queue.tmpl Removed striped class from queues table
templates/admin/packages/list.tmpl Removed striped class from packages list table
templates/admin/org/list.tmpl Removed striped class from organization list table
templates/admin/notice.tmpl Removed striped class from system notice list table
templates/admin/emails/list.tmpl Removed striped class from emails list table
templates/admin/cron.tmpl Removed striped class from cron tasks table
templates/admin/auth/list.tmpl Removed striped class from authentication sources table

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@a1012112796
Copy link
Member

Why? I think when the table is relatively large, displaying it this way helps avoid misreading rows. Or, it may be necessary to add a feature that highlights the currently focused row.

@silverwind
Copy link
Member Author

It's a stylistic choice only. I find striped tables ugly and GitHub also does not use such a design. We removed the same strips from the commits list a long time ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/frontend modifies/templates This PR modifies the template files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants