Open
Conversation
- if statement returned 2x the same, was left over from testing - bezier dont need to store start and end vars as they are not used anymore anywhere, just needed for local computes
bircni
commented
Mar 16, 2026
bircni
commented
Mar 16, 2026
bircni
commented
Mar 16, 2026
bircni
commented
Mar 16, 2026
bircni
commented
Mar 16, 2026
Contributor
Author
bircni
left a comment
There was a problem hiding this comment.
Self reviewed - did not find an issue for now
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restyles the Actions workflow dependency graph in the run summary view to a more compact, horizontal layout with updated node/edge visuals, and extends the devtest mock data to better exercise the new presentation (long names + more statuses).
Changes:
- Switched graph layout/orientation and updated spacing/edge routing to use “elbow” (orthogonal) connectors.
- Updated node rendering to a flatter card style with ports and a status icon via
ActionRunStatus. - Expanded devtest mock jobs to include additional statuses and a long job name for truncation/layout testing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| web_src/js/components/WorkflowGraph.vue | Implements the new graph layout, edge routing, node visuals, and status icon rendering. |
| routers/web/devtest/mock_actions.go | Adds more mock jobs/statuses and a long job name to validate the new graph styling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
…tyling - Replace hasIncomingEdge/hasOutgoingEdge linear scans with precomputed Sets for O(1) lookups per node render - Inline set lookups directly in template, removing one-off wrapper functions - Remove dead highlight logic from getEdgeStyle(); highlight styling is solely handled by .highlighted-edge CSS class
Contributor
Author
|
@silverwind could you have a look at it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As @silverwind requested in #36883 I restyled the workflow graph
Before
After
@xDarkmanx maybe you want to have a look at this, too as you introduced the workflows