Skip to content

Restyle Workflow Graph#36912

Open
bircni wants to merge 5 commits intogo-gitea:mainfrom
bircni:feature/restyle-workflow-graph
Open

Restyle Workflow Graph#36912
bircni wants to merge 5 commits intogo-gitea:mainfrom
bircni:feature/restyle-workflow-graph

Conversation

@bircni
Copy link
Contributor

@bircni bircni commented Mar 16, 2026

As @silverwind requested in #36883 I restyled the workflow graph

Before

After

@xDarkmanx maybe you want to have a look at this, too as you introduced the workflows

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 16, 2026
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/frontend labels Mar 16, 2026
@bircni bircni marked this pull request as ready for review March 16, 2026 20:14
@bircni bircni marked this pull request as draft March 16, 2026 20:38
@bircni bircni marked this pull request as draft March 16, 2026 20:38
- if statement returned 2x the same, was left over from testing
-  bezier dont need to store start and end vars as they are not used anymore anywhere, just needed for local computes
Copy link
Contributor Author

@bircni bircni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self reviewed - did not find an issue for now

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restyles the Actions workflow dependency graph in the run summary view to a more compact, horizontal layout with updated node/edge visuals, and extends the devtest mock data to better exercise the new presentation (long names + more statuses).

Changes:

  • Switched graph layout/orientation and updated spacing/edge routing to use “elbow” (orthogonal) connectors.
  • Updated node rendering to a flatter card style with ports and a status icon via ActionRunStatus.
  • Expanded devtest mock jobs to include additional statuses and a long job name for truncation/layout testing.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
web_src/js/components/WorkflowGraph.vue Implements the new graph layout, edge routing, node visuals, and status icon rendering.
routers/web/devtest/mock_actions.go Adds more mock jobs/statuses and a long job name to validate the new graph styling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

…tyling

- Replace hasIncomingEdge/hasOutgoingEdge linear scans with precomputed
  Sets for O(1) lookups per node render
- Inline set lookups directly in template, removing one-off wrapper functions
- Remove dead highlight logic from getEdgeStyle(); highlight styling is
  solely handled by .highlighted-edge CSS class
@bircni bircni marked this pull request as ready for review March 17, 2026 17:58
@bircni
Copy link
Contributor Author

bircni commented Mar 19, 2026

@silverwind could you have a look at it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/frontend modifies/go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants