Open
Conversation
- Enable a few more rules, fix issues - peerDependencyRules for eslint-plugin-github unrestricted, the plugin works in v10, but does not declare compatibility. - Added eslint-plugin-de-morgan, no violations.
silverwind
commented
Mar 19, 2026
Not needed, was in my personal config for react reasons. Signed-off-by: silverwind <me@silverwind.io>
delvh
approved these changes
Mar 19, 2026
Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>
Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>
Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>
Member
Author
|
|
Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the linting/tooling stack to ESLint v10 and adjusts web TS/Vue code to satisfy newly enabled rules while tightening global window.config typing.
Changes:
- Bump ESLint to v10 and refresh related eslint/* plugins; add
eslint-plugin-de-morganand pnpm peer dependency rule override. - Tighten
window.config.pageData/window.config.notificationSettingstypings and update call sites accordingly. - Fix newly surfaced lint issues (catch clause typing, string conversions, DOM API typing).
Reviewed changes
Copilot reviewed 14 out of 16 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| web_src/js/vitest.setup.ts | Updates test window config to match stricter notificationSettings typing |
| web_src/js/utils.ts | Normalizes caught errors to Error objects for promise rejections |
| web_src/js/modules/diff-file.ts | Exports DiffFileTreeData and applies non-null assertions for pageData |
| web_src/js/globals.d.ts | Adds explicit typing for pageData fields and notificationSettings |
| web_src/js/features/repo-search.ts | Adjusts FormData handling to satisfy stricter lint/type rules |
| web_src/js/features/pull-view-file.ts | Tightens prReview typing and ensures string conversions in DOM operations |
| web_src/js/features/common-fetch-action.ts | Adjusts query param building with FormData values |
| web_src/js/features/citation.ts | Tightens citation file content typing |
| web_src/js/components/RepoRecentCommits.vue | Marks repoLink as required at usage sites |
| web_src/js/components/RepoCodeFrequency.vue | Marks repoLink as required at usage sites |
| web_src/js/components/PullRequestMergeForm.vue | Marks merge form page data as required at usage sites |
| web_src/js/components/DashboardRepoList.vue | Adds richer TS types for repo list data and ref handling |
| updates.config.ts | Removes excludes now that ESLint 10 migration is done |
| package.json | Upgrades eslint/tooling deps and adds pnpm peerDependencyRules override |
| eslint.config.ts | Enables additional rules and configures new plugin rules |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-Authored-By: Claude (Opus 4.6) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
valueissues are false-positives.window.pageDataandwindow.notificationSettings.