Use json.Number when UnmarshalJSON'ing to JSONMap #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR go-gorm#202 made an equivalent change to .Scan() previously: commit 56bb801 Author: Long Le <[email protected]> Date: Tue Apr 11 10:17:44 2023 +0700 Use json.Number when scan to JSONMap (go-gorm#202) This commit makes the equivalent change to .UnmarshalJSON, so that the value is consistently correct whether it originates in the database or in a JSON object to be decoded. This commit also adds a test validating that, which fails without this commit: $ go test ./... 2025/10/23 16:06:37 testing sqlite3... --- FAIL: TestJSONMap_Unmarshal (0.00s) utils.go:40: datatypes/json_map_test.go:193: expect: 1085238870184050699, got 1085238870184050688 but passes with this commit. Co-Authored-By: Jeff Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
PR #202 made an equivalent change to .Scan() previously:
This commit makes the equivalent change to .UnmarshalJSON, so that the value is consistently correct whether it originates in the database or in a JSON object to be decoded.
This commit also adds a test validating that, which fails without this commit:
but passes with this commit.
User Case Description
A
json.Unmarshal()ed value should be of the same type as a valueScan()ned from the database.