Merged
Conversation
|
This PR introduces a configurable clause security checker integrated into DO clause validation, with a new option to plug in custom handling that can delegate back to the default checker when needed. Affected Areas• This summary was automatically generated by @propel-code-bot |
| // Clauses specify Clauses | ||
| func (d *DO) Clauses(conds ...clause.Expression) Dao { | ||
| if err := checkConds(conds); err != nil { | ||
| if err := checkCondsWithChecker(conds, d.ClauseChecker); err != nil { |
There was a problem hiding this comment.
[Logic] Calling d.ClauseChecker will panic if DOConfig was never initialized (e.g., Table(...) returns a *DO without calling UseDB). That makes Clauses() unsafe on those instances. Guard against a nil DOConfig and pass a nil checker to fall back to CheckClause.
Suggested change
| if err := checkCondsWithChecker(conds, d.ClauseChecker); err != nil { | |
| var checker ClauseChecker | |
| if d.DOConfig != nil { | |
| checker = d.ClauseChecker | |
| } | |
| if err := checkCondsWithChecker(conds, checker); err != nil { |
Context for Agents
Calling `d.ClauseChecker` will panic if `DOConfig` was never initialized (e.g., `Table(...)` returns a `*DO` without calling `UseDB`). That makes `Clauses()` unsafe on those instances. Guard against a nil `DOConfig` and pass a nil checker to fall back to `CheckClause`.
```suggestion
var checker ClauseChecker
if d.DOConfig != nil {
checker = d.ClauseChecker
}
if err := checkCondsWithChecker(conds, checker); err != nil {
```
File: do.go
Line: 175
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests