Skip to content

fix: prevent interface type array from causing runtime errors #7418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: prevent interface type array from causing runtime errors #7418

wants to merge 3 commits into from

Conversation

KEHyeon
Copy link

@KEHyeon KEHyeon commented Apr 13, 2025

  • Do only one thing
  • Non breaking API changes
  • [v] Tested

What did this pull request do?

fix: prevent interface type array from causing runtime errors
It has been modified to find out the value when it is an interface array.

User Case Description

type UserInterface interface {
	GetName() string
}

db.Table("users").Create([]UserInterface{UserToUserInterface(&userData)})

In this case, create is allowed.

jinzhu
jinzhu reviewed May 21, 2025
View reviewed changes
tests/create_test.go
@@ -791,3 +791,15 @@ func TestCreateFromMapWithTable(t *testing.T) {
t.Errorf("failed to create data from map with table, @id != id")
}
}

func TestCreateWithInterfaceArrayType(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it work for queries with an interface array as result?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinzhu jinzhu jinzhu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KEHyeon @jinzhu