Skip to content

Propagate WithResult errors and refresh CI Go/TiDB setup#7721

Closed
qqxhb wants to merge 8 commits intomasterfrom
ci/fix-tidb-and-go-matrix
Closed

Propagate WithResult errors and refresh CI Go/TiDB setup#7721
qqxhb wants to merge 8 commits intomasterfrom
ci/fix-tidb-and-go-matrix

Conversation

@qqxhb
Copy link
Member

@qqxhb qqxhb commented Mar 3, 2026

This updates the CI workflow to address widespread failures on PRs:

  • Replace Icemap/tidb-action@main with a TiDB service container (pingcap/tidb:v6.5.0) and a simple readiness probe.
  • Update the Go matrix to use 1.25 + stable to avoid dependency minimum-Go-version failures seen on 1.24.

Context:

  • TiDB job failure: docker client version too old (min API 1.44)
  • Some Go 1.24 jobs fail with go-mssqldb requiring go >= 1.25.7

@propel-code-bot
Copy link
Contributor

propel-code-bot bot commented Mar 3, 2026

It also improves WithResult error propagation so callers can directly inspect errors and adds a new gorm generics test, with related test adjustments to validate the behavior.

Affected Areas

generics.go
gorm.go
.github/workflows/tests.yml
generics_withresult_test.go
tests/upsert_test.go

This summary was automatically generated by @propel-code-bot

@propel-code-bot propel-code-bot bot changed the title ci(tests): replace tidb action and update Go matrix ci(tests): switch TiDB to service and update test matrix Mar 3, 2026
@propel-code-bot propel-code-bot bot changed the title ci(tests): switch TiDB to service and update test matrix ci(tests): use TiDB service, update Go matrix, fix upsert test Mar 3, 2026
@propel-code-bot propel-code-bot bot changed the title ci(tests): use TiDB service, update Go matrix, fix upsert test Fix many-to-many join inserts and update CI Go/TiDB setup Mar 3, 2026
@propel-code-bot propel-code-bot bot changed the title Fix many-to-many join inserts and update CI Go/TiDB setup Update CI Go matrix and TiDB service setup Mar 3, 2026
Add Error field to WithResult result and set it via AddError; include a sqlite-based test.
@propel-code-bot propel-code-bot bot changed the title Update CI Go matrix and TiDB service setup Propagate WithResult errors and refresh CI Go/TiDB setup Mar 6, 2026
@qqxhb qqxhb closed this Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant