fix: isolate zero-value Model on Statement clone#7729
Closed
Conversation
Prevent stale primary-key WHERE leaking across cloned sessions during Updates. Fixes #7725
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7725.
When Statement.clone() reuses the same zero-value *Model pointer (e.g. Model(&User{})) across cloned sessions, the update path can write the primary key back into that shared Model, and subsequent clones may append a stale pk predicate into WHERE
This isolates Model() only when it is a pointer to a zero-value struct, preventing cross-call contamination while leaving non-zero models untouched.
Tests: go test ./...