fix: parsing DDL with TAB between column name and the column type#222
Merged
jinzhu merged 1 commit intogo-gorm:masterfrom Jan 31, 2026
Merged
fix: parsing DDL with TAB between column name and the column type#222jinzhu merged 1 commit intogo-gorm:masterfrom
jinzhu merged 1 commit intogo-gorm:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the DDL parser where tab characters between column names and types were incorrectly treated as quote delimiters, causing the parser to fail to split column definitions properly.
Changes:
- Removed
\tfromsqliteSeparatorto prevent tabs from being treated as quote characters - Added a test case to verify that DDL with tabs between column identifiers and types is parsed correctly
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ddlmod.go | Removed \t from sqliteSeparator variable to fix tab character handling |
| ddlmod_test.go | Added test case for parsing DDL with tab characters between column names and types |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
Remove tab character (
\t) fromsqliteSeparator.sqlite/ddlmod.go
Lines 58 to 79 in 7818dfd
When a tab character (
\t) is present between the identifier and its type,separatorRegexp.MatchString(sc)can match and the code toggles the quote state incorrectly. The incorrect quote state causes the parser to ignore commas and therefore fail to split fields properly.User Case Description
When parsing DDL that uses a tab character (
\t) as whitespace between an identifier and its type, the parser can misinterpret the column list and return the wrong number of columns.Reproduction DDL:
Expected result should have two columns:
Only one column is actually returned (the parser fails to split the column definitions correctly):