Skip to content

remove redundant call in filesys RemoveDir#458

Merged
go-jet merged 2 commits intogo-jet:developfrom
switchupcb:patch-1
Mar 16, 2025
Merged

remove redundant call in filesys RemoveDir#458
go-jet merged 2 commits intogo-jet:developfrom
switchupcb:patch-1

Conversation

@switchupcb
Copy link
Copy Markdown
Contributor

RemoveAll removes path and any children it contains. It removes everything it can but returns the first error it encounters. If the path does not exist, RemoveAll returns nil (no error). If there is an error, it will be of type [*PathError].

So, there is no need to check whether the directory exists.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.35%. Comparing base (33c1d9e) to head (77dc0bc).
Report is 37 commits behind head on develop.

Files with missing lines Patch % Lines
generator/template/process.go 50.00% 0 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #458      +/-   ##
===========================================
+ Coverage    91.28%   91.35%   +0.06%     
===========================================
  Files          134      134              
  Lines         7782     7759      -23     
===========================================
- Hits          7104     7088      -16     
+ Misses         509      504       -5     
+ Partials       169      167       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@go-jet go-jet changed the base branch from master to develop March 16, 2025 17:47
@go-jet
Copy link
Copy Markdown
Owner

go-jet commented Mar 16, 2025

Thanks. LGTM. 👍

@go-jet go-jet merged commit 0653036 into go-jet:develop Mar 16, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants