Open
Conversation
coryb
requested changes
Jun 18, 2020
Contributor
coryb
left a comment
coryb
left a comment
There was a problem hiding this comment.
Hey, add, div and mul should already be there via the inclusion of the sprig library:
http://masterminds.github.io/sprig/math.html
We can probably also remove sub in favor of the one in sprig (I think it was added before we used sprig).
Could you try your templates without those added functions to make sure the sprig usage works for you? I am fine with adding pctVal I dont think it was available via sprig.
Collaborator
|
@kottle Any interest in following up here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added to template extra functions to manipulate int:
My request is to add functions:
add: a+b
div: a/b
mult: a*b
pctVal: (size-val)*100/size