add --passwordsource global option#442
Open
chuckliu1979 wants to merge 4 commits intogo-jira:masterfrom
chuckliu1979:master
Open
add --passwordsource global option#442chuckliu1979 wants to merge 4 commits intogo-jira:masterfrom chuckliu1979:master
chuckliu1979 wants to merge 4 commits intogo-jira:masterfrom
chuckliu1979:master
Conversation
added 2 commits
September 9, 2021 13:19
catskul
reviewed
Nov 21, 2021
| gopkg.in/yaml.v2 v2.2.2 // indirect | ||
| ) | ||
|
|
||
| replace github.com/go-jira/jira => github.com/chuckliu1979/jira v1.0.30 //indirect |
Contributor
There was a problem hiding this comment.
oops, this probably shouldn't stay in.
Suggested change
| replace github.com/go-jira/jira => github.com/chuckliu1979/jira v1.0.30 //indirect |
Collaborator
There was a problem hiding this comment.
+1 we can't merge with this in
catskul
suggested changes
Dec 29, 2021
Contributor
catskul
left a comment
catskul
left a comment
There was a problem hiding this comment.
Need to fix the replace line in go.mod at least. Did not review the rest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for automation testing and/or CI/CD, it's good to have pipe login from stdin. at present we need add "password-source: stdin" in .jira.d/config.yml, it's not convenient. this pull request would better :
echo "password" | jira login --passwordsource stdin