Adds OnTableNotFound() error handler to Canal#1105
Merged
lance6716 merged 4 commits intogo-mysql-org:masterfrom Feb 23, 2026
Merged
Adds OnTableNotFound() error handler to Canal#1105lance6716 merged 4 commits intogo-mysql-org:masterfrom
lance6716 merged 4 commits intogo-mysql-org:masterfrom
Conversation
Contributor
Author
|
I made the handler name very specific, because there don't seem to be any other use cases that would really need handling in a similar manner. |
lance6716
reviewed
Feb 23, 2026
dveeden
reviewed
Feb 23, 2026
lance6716
approved these changes
Feb 23, 2026
Collaborator
lance6716
left a comment
lance6716
left a comment
There was a problem hiding this comment.
lgtm. please check dveeden's comment
Co-authored-by: Daniël van Eeden <github@myname.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1093 by introducing a new
OnTableNotFound()handler that receives the complete event for whatever it wants to do with it. The handler can subsequently return an error (new default behavior), which will fail the stream, ornilto ignore and skip the problem (old default behavior). It also fixes a minor issue where theevariable holding the event would previously be shadowed by an error var taking the same name.