Conversation
Signed-off-by: lance6716 <lance6716@gmail.com>
Collaborator
Author
|
@dveeden PTAL |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines the DSN compatibility rewrite used by the driver package so that tcp(...) host rewriting only applies to the host portion (avoiding accidental rewrites in credentials/query), and expands test coverage for tricky DSN inputs.
Changes:
- Tighten
compatDSNreto be anchored and only rewrite the hosttcp(...)segment. - Update the rewrite replacement to preserve the
mysql://prefix and optional userinfo. - Add DSN parsing tests for parentheses in query params and
tcp(...)appearing in passwords.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| driver/driver.go | Updates the compatibility regexp and replacement logic for tcp(...) DSN host rewriting. |
| driver/driver_test.go | Adds new DSN parsing test cases to validate the improved matching behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
Addressed Copilot comments: switched replacement to `` and added a DSN parse test for |
Collaborator
Author
|
@dveeden PTAL |
dveeden
approved these changes
Feb 24, 2026
# Conflicts: # driver/driver_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as the comment in #1104 (comment)