CI: Update nolintlint config #991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`allow-leading-space: false` is not valid config anymore ``` $ golangci-lint config verify jsonschema: "linters-settings.nolintlint" does not validate with "/properties/linters-settings/properties/nolintlint/additionalProperties": additionalProperties 'allow-leading-space' not allowed Failed executing command with error: the configuration contains invalid elements ```
dveeden
force-pushed
the
ci_nolintlint_leading_space
branch
from
32588ad to
19f0abb
Compare
dveeden
force-pushed
the
ci_nolintlint_leading_space
branch
from
63c341a to
0ab5c04
Compare
lance6716
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow-leading-space: falseis not valid config anymoreAlso allow annotations:
https://github.com/golangci/golangci-lint-action/tree/v6/?tab=readme-ov-file#annotations
Needed for annotations to work:
Also set the Go version to 'stable' instead of a specific version and add 1.24 to the list.