Add retryable errors for deadlock and lock wait timeout#4
Open
dharkness wants to merge 1 commit intogo-mysql:masterfrom
Open
Add retryable errors for deadlock and lock wait timeout#4dharkness wants to merge 1 commit intogo-mysql:masterfrom
dharkness wants to merge 1 commit intogo-mysql:masterfrom
Conversation
Member
|
Thank you for the commit. Very ironic timing with #3 that adds lock wait time. Since PR 3 has a test (and was submitted first), let's merge that one first. Then could reuse your work off that? |
Author
|
Yeah, I saw #3 after submitting my PR. I saw no changes for a while so wasn't sure if you'd want the PR, but if so I can add a test and rebase after you merge the other PR. Thanks for creating this package. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two retryable lock-related errors:
1205: ER_LOCK_WAIT_TIMEOUT
Lock wait timeout exceeded; try restarting transaction
1213: ER_LOCK_DEADLOCK
Deadlock found when trying to get lock; try restarting transaction