Merged
Conversation
* Exported API reduced to what go-swagger is calling: all other exported symbols are now unexported * carried out all simple relinting actions * modernized statements (use iterators, ...) * used nolint where appropriate for now, pending future deeper refactoring actions * refactored deeply nested structures and complex functions (including test code) * refactored code duplication * relaxed a few linting constraints (complexity, maintainability index) No change in semantics, no change in test assertions Signed-off-by: Frédéric BIDON <fredbi@yahoo.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3 +/- ##
==========================================
- Coverage 71.80% 71.63% -0.17%
==========================================
Files 13 14 +1
Lines 3862 3794 -68
==========================================
- Hits 2773 2718 -55
+ Misses 785 761 -24
- Partials 304 315 +11 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exported API reduced to what go-swagger is calling: all other exported symbols are now unexported
carried out all simple relinting actions
modernized statements (use iterators, ...)
used nolint where appropriate for now, pending future deeper refactoring actions
refactored deeply nested structures and complex functions (including test code)
refactored code duplication
relaxed a few linting constraints (complexity, maintainability index)
No change in semantics, no change in test assertions
Change type
Please select: 🆕 New feature or enhancement|🔧 Bug fix'|📃 Documentation update
Short description
Fixes
Full description
Checklist