chore(deps): deprecated dependency to opentracing #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixes go-openapi#365 This PR deprecates the WithOpenTracing runtime option, in favor the WithOpenTelemetry option. The WithOpenTracing method remains exposed, so programs that build with that one don't break, but options are ignored and it returns an opentelemetry-enabled transport. A new independent is introduced to provide backward-compatibility to users who are not able to transition to opentelemetry. Technically, the runtime repo now moves to a multi-modules mono-repo structure, similar to github.com/go-openapi/swag. The necessary CI changes are applied. Signed-off-by: Frederic BIDON <[email protected]>
fredbi
force-pushed
the
fix/365-deprecaed-opentracing
branch
from
54ade52 to
5bf5373
Compare
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (16.66%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #366 +/- ##
==========================================
- Coverage 81.78% 78.59% -3.20%
==========================================
Files 49 50 +1
Lines 4079 4087 +8
==========================================
- Hits 3336 3212 -124
- Misses 630 765 +135
+ Partials 113 110 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates the WithOpenTracing runtime option, in favor the WithOpenTelemetry option.
The WithOpenTracing method remains exposed, so programs that build with that one don't break, but options are ignored and it returns an opentelemetry-enabled transport.
A new independent is introduced to provide backward-compatibility to users who are not able to transition to opentelemetry.
Technically, the runtime repo now moves to a multi-modules mono-repo structure, similar to github.com/go-openapi/swag. The necessary CI changes are applied.
Change type
Please select: 🆕 New feature or enhancement|🔧 Bug fix'|📃 Documentation update
Short description
Fixes
Full description
Checklist