Skip to content

Conversation

@xyz27900
Copy link
Contributor

Fixes Or Enhances

Fixes #1513

This PR adds 14 ISO 3166-2 subdivision codes that are currently missing from the validator. These codes were officially added to the ISO 3166-2 standard between 2014 and 2023.

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@xyz27900 xyz27900 requested a review from a team as a code owner December 20, 2025 22:53
@coveralls
Copy link

Coverage Status

coverage: 73.749%. remained the same
when pulling 2180c59 on xyz27900:fix-1513-iso31662-codes
into b0e4ba2 on go-playground:master.

Copy link
Member

@zemzale zemzale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will wait a bit for someone else maybe has some comments, if not will merge it

Copy link
Contributor

@deankarn deankarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure all of the new additions are valid, could you provide sources?

Copy link
Contributor

@deankarn deankarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM verified against a couple data sources

@deankarn deankarn merged commit 5010f83 into go-playground:master Dec 24, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing ISO 3166-2 subdivision codes in iso3166_2 validator

4 participants