fix: prevent unique nil marker collisions - #1628
Open
fzlzjerry wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Or Enhances
Fixes #1627.
Use a function-local named type for the nil marker so it cannot compare equal to a legitimate anonymous
struct{}value. The existing single-nil and duplicate-value semantics stay unchanged.Cover slices, arrays, maps, pointer fields and nil parent pointers, with controls for duplicates and named structs.
The new regression fails on the five collision paths before the fix.
Full race/coverage suites pass on Go 1.25.14 and 1.26.8; golangci-lint v2.13.1 passes.
Allocation counts are unchanged across the 66 existing benchmarks and four targeted successful
uniquepaths. Timing samples vary, so no throughput improvement is claimed.Tests exist or have been written that cover this particular change.
@go-playground/validator-maintainers