Skip to content

Update defaults.go#1110

Open
sethgrid wants to merge 1 commit intogo-rod:mainfrom
sethgrid:patch-1
Open

Update defaults.go#1110
sethgrid wants to merge 1 commit intogo-rod:mainfrom
sethgrid:patch-1

Conversation

@sethgrid
Copy link

@sethgrid sethgrid commented Sep 5, 2024

enable env var ROD_FLAGS that works the same as -rod flags from cmd line. I was regularly getting "-rod" flag not defined errors failing my tests (even though the flag was being honored) and decided to side step the flags with an env var

Development guide

Link

Test on local before making the PR

go run ./lib/utils/simple-check

enable env var ROD_FLAGS that works the same as -rod flags from cmd line
@ysmood
Copy link
Member

ysmood commented Sep 7, 2024

I was regularly getting "-rod" flag not defined errors failing my tests (even though the flag was being honored)

Could you provide some code to reproduce your issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants