add GetBody in hijack LoadResponse request for http2 retry#1128
Open
pyneda wants to merge 2 commits intogo-rod:mainfrom
Open
add GetBody in hijack LoadResponse request for http2 retry#1128pyneda wants to merge 2 commits intogo-rod:mainfrom
pyneda wants to merge 2 commits intogo-rod:mainfrom
Conversation
ysmood
reviewed
Oct 20, 2024
Member
ysmood
left a comment
ysmood
left a comment
There was a problem hiding this comment.
Could you add at least a test for it?
Author
Attempted to set up a test case using an HTTP/2 test server and a client that forces retries to reproduce the original issue. However, I wasn't able to replicate the same error within a test case. As a fallback, added a simpler test that ensures the request body is correctly propagated through redirects and verifies that the Some related issues: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for the following error