Skip to content

fix: element screenshot is incorrect when DevicePixelRatio != 1 #1198 #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kvii wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: element screenshot is incorrect when DevicePixelRatio != 1 #1198 #1200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions element.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,7 +673,14 @@ func (el *Element) BackgroundImage() ([]byte, error) {

// Screenshot of the area of the element.
func (el *Element) Screenshot(format proto.PageCaptureScreenshotFormat, quality int) ([]byte, error) {
err := el.ScrollIntoView()
// this value can be modified by user.
res, err := el.Eval(`()=>window.devicePixelRatio || 1`)
if err != nil {
return nil, err
}
scale := res.Value.Num()

err = el.ScrollIntoView()
if err != nil {
return nil, err
}
Expand All @@ -698,10 +705,10 @@ func (el *Element) Screenshot(format proto.PageCaptureScreenshotFormat, quality

// TODO: proto.PageCaptureScreenshot has a Clip option, but it's buggy, so now we do in Go.
return utils.CropImage(bin, quality,
int(box.X),
int(box.Y),
int(box.Width),
int(box.Height),
int(box.X*scale),
int(box.Y*scale),
int(box.Width*scale),
int(box.Height*scale),
)
}

Expand Down
Loading