fix: update RevisionPlaywright to 1202 for Linux ARM64 support #1222
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falconws
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update
RevisionPlaywrightfrom1124to1202to fix Chromium download failure on Linux ARM64 architecture.Problem
On Linux ARM64, the browser launcher fails with the following error:
can't find a browser binary for your OS, the doc might help https://go-rod.github.io/#/compatibility?id=os : Not able to find a valid URL to download
[https://storage.googleapis.com/chromium-browser-snapshots//1321438/ https://registry.npmmirror.com/-/binary/chromium-browser-snapshots//1321438/
https://playwright.azureedge.net/builds/chromium/1124/chromium-linux-arm64.zip]
Root Cause
The
RevisionPlaywrightconstant (1124) is outdated. The Playwright CDN no longer hosts the Chromium build for revision 1124. The current Playwright uses revision 1202 (Chromiumversion 143.0.7499.25).
Reference: microsoft/playwright browsers.json
Changes
RevisionPlaywrightfrom1124to1202inlib/launcher/revision.goTesting
Verified that Chromium downloads successfully on Linux ARM64 after this change.
Ref: #1045