Add partial support for sections properties#47
Open
neclepsio wants to merge 18 commits intogo-shiori:mainfrom
Open
Add partial support for sections properties#47neclepsio wants to merge 18 commits intogo-shiori:mainfrom
neclepsio wants to merge 18 commits intogo-shiori:mainfrom
Conversation
Monirzadeh
reviewed
Oct 18, 2024
| } else { | ||
|
|
||
| parentRelativePath := filepath.Join(xhtmlFolderName, parent) | ||
| parentRelativePath := path.Join(xhtmlFolderName, parent) |
There was a problem hiding this comment.
why change filepath to path?
filepath choose the target runtime's file separators OS so it work correctly on window and Linux that has different separator
Monirzadeh
reviewed
Oct 18, 2024
Comment on lines
37
to
49
| 1. Download and extract EPUBCheck in the root directory of this project, e.g. | ||
|
|
||
| ``` | ||
| wget https://github.com/IDPF/epubcheck/releases/download/v4.2.5/epubcheck-4.2.5.zip | ||
| unzip epubcheck-4.2.5.zip | ||
| wget https://github.com/IDPF/epubcheck/releases/download/v5.1.0/epubcheck-5.1.0.zip | ||
| unzip epubcheck-5.1.0.zip | ||
| ``` | ||
|
|
||
| You can use this command to download and extract the latest versions of EPUBCheck (recommended). | ||
|
|
||
| ``` | ||
| curl -s https://api.github.com/repos/w3c/epubcheck/releases/latest | awk -F': "' '/browser_download_url/ && /epubcheck/ {gsub(/"$/, "", $2); print $2}' | xargs curl -Lo epubcheck.zip | ||
| unzip epubcheck.zip | ||
| ``` |
Author
There was a problem hiding this comment.
It's what you proposed in the previous pull request.
Monirzadeh
requested changes
Oct 18, 2024
Monirzadeh
left a comment
Monirzadeh
left a comment
There was a problem hiding this comment.
Thanks for PR i left some comment of them
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
==========================================
+ Coverage 82.04% 82.45% +0.40%
==========================================
Files 12 12
Lines 997 1020 +23
==========================================
+ Hits 818 841 +23
Misses 114 114
Partials 65 65 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40 and #46.