Support for multiple map renderers#134
Open
dwoznicki wants to merge 11 commits intogo-spatial:masterfrom
Open
Conversation
Member
|
@dwoznicki just a quick follow up on this PR. It's not lost we have just been navigating several other things. We also had to update the package-lock.json file as the CI was timing out. If you're interested in helping with the linter errors you can see what's happening in the Netlify build on this PR: #136 Thanks again for the contribution. |
fixes exceptions that blocked Netlify build
…eturning anything
Author
|
@ARolek Well, it looks like the build was failing due to a |
Member
|
@dwoznicki can you rebase against |
added 5 commits
November 17, 2022 13:25
…eturning anything
…maplibre-renderer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #133
This PR adds a UI control to change the map render at runtime. Here are some notes/questions for the maintainer(s):
MapMapbox.jsxto accept multiple renderers instead of creating a new map component because, as far as I can tell, maplibre-gl v2 is completely backwards compatible with mapbox-gl v1. This may not be the case with other renderers, so perhaps there should be a new map component for each renderer (e.g.MapMapbox.jsx,MapMapLibre.jsx), even if the Mapbox and MapLibre map components are redundant.npm installseems to have automatically changed the lock file version to 2, generating a large number of changes topackage-lock.json. I believe this is because I'm running node v16.15.0 and npm 8.5.5 on my machine. If this is undesirable, let me know what node version I should be working on.