Fix SAP HANA mvt provider. Upgrade driver version and dependencies#1086
Draft
remi-sap wants to merge 1 commit intogo-spatial:masterfrom
Draft
Fix SAP HANA mvt provider. Upgrade driver version and dependencies#1086remi-sap wants to merge 1 commit intogo-spatial:masterfrom
remi-sap wants to merge 1 commit intogo-spatial:masterfrom
Conversation
Member
|
@mrylov you were the main contributor to this part of the codebase. Are you still available for a review? |
Member
Author
Member
|
@remi-sap great! |
Author
|
Besides vulnerabilities, tests for HANA as a provider are failing. |
Member
I will get this fixed up in master. |
Contributor
|
I've prepared a working fix in my forked repository, see mrylov@f462197. @remi-sap, could you please adjust your change accordingly? Thank you and kind regards |
Member
|
The govulncheck issue is resolved in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I had an issue connecting tegola to SAP HANA Cloud as an MVT provider.
I noticed the driver for SAP HANA was old so I refreshed it, hence the hundreds of changed files under vendor/