feat: wildcard match aliases #2234
Open
+85
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmaerten
requested review from
andreynering,
pd93 and
Copilot
and removed request for
andreynering
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for wildcard matching of task aliases by refactoring task-matching logic into a single function, FindMatchingTasks, and updating related components.
- Updated task definitions in Taskfile.yml to include alias patterns
- Modified WildcardMatch in taskfile/ast/task.go to iterate over both task names and aliases
- Adjusted FindMatchingTasks and GetTask in task.go to handle conflicts when matching aliases
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| testdata/wildcards/Taskfile.yml | Added alias definitions to support wildcard alias matching |
| taskfile/ast/task.go | Updated WildcardMatch to check both task names and aliases in one loop |
| task_test.go | Added test case to verify alias based matching |
| task.go | Refactored FindMatchingTasks and GetTask to return conflict errors for multiple alias matches |
Files not reviewed (1)
- website/docs/usage.mdx: Language not supported
vmaerten
added
area: ui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The wildcard did not match aliases.
I've done a bit of refactoring and moved some code into
FindMatchingTasks, but its signature has changed. Is it OK for the package API, or should I consider another solution ?The goal was for
FindMatchingTasksto also handle matching aliases (even without wildcards). It felt more logical to group all the task-matching logic in one place.Fixes #1900
NOTE: I modified the test, but I did not migrate it to the new system yett