fix: Task failure errors include stack of running tasks. #2286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if a task was run as a dependency of another task, the error message simply reported something like: ``` exit status 1 ``` It is desirable instead to name the root task and all child tasks in the tree to the failing task. After this PR, the error message will read: ``` task: Failed to run task "root": task: Failed to run task "failing-task": exit status 1 ```
|
ping @pd93 / @andreynering ? |
|
@GrahamDennis I know we are overdue on reviewing many issues and PRs. We are very limited in time. I self-requested a review, and will take a look once possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if a task was run as a dependency of another task, the error message simply reported something like:
It is desirable instead to name the root task and all child tasks in the tree to the failing task.
After this PR, the error message will read:
Additionally, task errors did not use the task's
labelname when present, which they now will.