Skip to content

fix: return taskrc config even if there is an error #2461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: return taskrc config even if there is an error #2461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f4ac6a2
fix: return taskrc config even if there is an error
vmaerten Oct 6, 2025
ade0176
remove debug
vmaerten Oct 10, 2025
d72be26
remove debug
vmaerten Oct 10, 2025
e4a9e2a
remove debug
vmaerten Oct 10, 2025
04ae322
remove debug
vmaerten Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions experiments/experiments.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,12 @@ var xList []Experiment

func Parse(dir string) {
config, _ := taskrc.GetConfig(dir)

ParseWithConfig(dir, config)
}

func ParseWithConfig(dir string, config *ast.TaskRC) {
// Read any .env files
readDotEnv(dir)

// Initialize the experiments
GentleForce = New("GENTLE_FORCE", config, 1)
RemoteTaskfiles = New("REMOTE_TASKFILES", config, 1)
Expand Down
4 changes: 2 additions & 2 deletions taskrc/taskrc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,11 @@ func GetConfig(dir string) (*ast.TaskRC, error) {
// Find all the nodes from the given directory up to the users home directory
absDir, err := filepath.Abs(dir)
if err != nil {
return nil, err
return config, err
}
entrypoints, err := fsext.SearchAll("", absDir, defaultTaskRCs)
if err != nil {
return nil, err
return config, err
}

// Reverse the entrypoints since we want the child files to override parent ones
Expand Down
Loading