Update Harfbuzz implementation; upgrade to Unicode 17#224
Closed
benoitkugler wants to merge 27 commits intomainfrom
Closed
Update Harfbuzz implementation; upgrade to Unicode 17#224benoitkugler wants to merge 27 commits intomainfrom
benoitkugler wants to merge 27 commits intomainfrom
Conversation
benoitkugler
requested review from
andydotxyz and
whereswaldon
as code owners
Contributor
Author
|
Superseded by #225 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ports the latest changes in the Harfbuzz C++ implementation (roughly v12.3.0).
It also bump our Unicode version to 17, and upgrade our Unicode Line Breaking implementation (in the
segmenterpackage).There is no API change, expect for a change in the method
Face.GlyphVOriginwhose signature is nowGlyphVOrigin(glyph GID) (x, y float32). This method is essentially used internally in Harfbuzz, and this change should not affect end users.