fix(mail): disable queue when mailer disabled #2069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the mailer is disabled, don't create the mail queue to prevent SendMail from blocking indefinitely. Add a guard in SendMail to return early when the mailer is disabled or queue is nil. Closes: #1080
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SendMail()from blocking indefinitelySendMail()to return early when mailer is disabled or queue is nilThis implements the changes from #1080 with the review feedback addressed (using
package notificationsinstead ofpackage notifications_test).Test plan
mage test:filter TestNotifyDoesNotBlockWhenMailerDisabled- passesmage test:filter TestNotify- all notification tests passmage lint- 0 issuesCloses #1080