Ban VanillaPlus v1.1.4.0 - Controller Navigation Interference

[wolfcomp]

Having core features in the game broken due to a plugin should not be allowed.

[KazWolfe]

You really need to clarify what is broken.

cc @MidoriKami

---

Edit: (per Kami via Discord) This has apparently been a long-standing issue and they don't think a ban is necessary for this version, and that this should also affect anything that makes custom addons.

[wolfcomp]

Any vanillaplus addon open breaks the controller navigation option from the base game.

[MidoriKami]

I did not request for VanillaPlus to be banned, I think it's bad etiquette to request a ban without speaking to the dev of the plugin beforehand. I have in the past requested people ban my plugins for me as I may have been busy/at work, but that was not the case here.

Context about the issue at hand, the "core feature" that was being bugged was the following:

With any KamiToolKit.NativeAddon window open, using a controller cycle between windows, once a custom window becomes selected this way, continuing to use controller to try and cycle the windows no longer functions, the controller nav cursor becomes "stuck" of the custom window.

After some investigation it was found that this is due to the window not having a FocusNode set in the addon, KamiToolKit.NativeAddon windows have never set this value, so this bug is not new at all, it was only recently discovered.

Given that it's been this way for months, and only discovered recently, that means this is a rather rare occurrence for someone to do, and doesn't warrant the plugin being banned. Additionally, controller nav can be restored by simply closing the custom window, or use any other input method to select a different window.

The bug was fixed in KamiToolKit the same day the bug was discovered: MidoriKami/KamiToolKit@f07c53a

Any plugins that create custom native addons will have to update KTK to have the issue resolved in their respective plugins, however I believe the devs are free to do this at their leisure.

[wolfcomp]

If dalamud had a proper library system that would allow us to ban specific versions of binaries it would have been targeted directly at the tool kit and not the plugin it self that caused the issue.

[philpax]

I'm going to close this because, while this is not an ideal situation, I believe Kami has taken the appropriate mitigation steps and the breakage is not significant enough to merit more action.