docs: update CopyElement benchmark walkthrough to reflect current implementation#527
Closed
Ganesh-reddy005 wants to merge 2 commits intogoatshriek:latestfrom
Closed
docs: update CopyElement benchmark walkthrough to reflect current implementation#527Ganesh-reddy005 wants to merge 2 commits intogoatshriek:latestfrom
Ganesh-reddy005 wants to merge 2 commits intogoatshriek:latestfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## latest #527 +/- ##
=======================================
Coverage 90.82% 90.82%
=======================================
Files 47 47
Lines 4576 4576
Branches 609 609
=======================================
Hits 4156 4156
Misses 276 276
Partials 144 144 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
goatshriek
requested changes
Oct 1, 2025
Owner
goatshriek
left a comment
goatshriek
left a comment
There was a problem hiding this comment.
Please take another look at this - you've replaced the code that was being tested, instead of the benchmark code as the original issue describes.
| ```c | ||
| // first create a new element | ||
| copy = stumpless_new_element( stumpless_get_element_name( element ) ); | ||
| static void CopyElement(benchmark::State& state){ |
Owner
There was a problem hiding this comment.
You've replaced the wrong code snippet - please leave the example C code, and replace the benchmark code instead (starting on line 65 in the original file).
goatshriek
requested changes
Oct 2, 2025
Owner
goatshriek
left a comment
goatshriek
left a comment
There was a problem hiding this comment.
Please address the previous review's comment.
Owner
|
This change has been covered by #549. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the documentation snippet in
docs/benchmark.mdunder the "Walkthrough: Improving stumpless_copy_element" section. The previous snippet showed an outdated manual param-copying approach. This update replaces it with the current implementation fromtest/performance/element.cpp, which usesstumpless_copy_element()directly.This improves clarity and ensures the documentation accurately reflects the benchmark code used today.
Fixes #444