Skip to content

Conversation

PeshekDotDev
Copy link
Contributor

Details

We tell people to install krb5 with brew on dev env setup. The output from running brew install krb5 tells people they have to update their path to add krb5 manually. This is very easy to miss, and without it in your path, the tests in authentik/sources/kerberos will hang infinitely.

This PR automatically updates your path to add the brew install of krb5 when the test suite is run via make test or make all


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make docs)

@PeshekDotDev PeshekDotDev requested a review from a team as a code owner October 2, 2025 16:41
Copy link

netlify bot commented Oct 2, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 60040c9
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/68f08f2dbd6a3b0008608a3e
😎 Deploy Preview https://deploy-preview-17223--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Oct 2, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 60040c9
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/68f08f2d8e9f350008d71eb0
😎 Deploy Preview https://deploy-preview-17223--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Oct 2, 2025

Deploy Preview for authentik-integrations ready!

Name Link
🔨 Latest commit 60040c9
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/68f08f2d355195000806116e
😎 Deploy Preview https://deploy-preview-17223--authentik-integrations.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.92%. Comparing base (b075056) to head (60040c9).
⚠️ Report is 50 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17223      +/-   ##
==========================================
+ Coverage   92.68%   92.92%   +0.23%     
==========================================
  Files         868      868              
  Lines       47841    47863      +22     
==========================================
+ Hits        44342    44476     +134     
+ Misses       3499     3387     -112     
Flag Coverage Δ
e2e 45.27% <ø> (+1.16%) ⬆️
integration 23.10% <ø> (-0.08%) ⬇️
unit 91.06% <ø> (+<0.01%) ⬆️
unit-migrate 91.11% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Makefile Outdated
Comment on lines 55 to 56
ifdef KRB5_EXISTS
PATH="$(shell brew --prefix krb5)/sbin:$(shell brew --prefix krb5)/bin:$$PATH" uv run coverage run manage.py test --keepdb authentik
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could probably just export the changed path and not need to duplicate command

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

each physical line in a Makefile recipe is executed in a separate shell instance, so we can't export, but I did find a way to inject the path in that is much cleaner

@PeshekDotDev
Copy link
Contributor Author

@BeryJu I made an additional minor update with this — you can now run make test path/to/tests to run specific folders tests. Let me know what you think of that. make test will still default to running all tests

Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-60040c98ed9e14af6b6fc91078f36c686433cb28
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-60040c98ed9e14af6b6fc91078f36c686433cb28

Afterwards, run the upgrade commands from the latest release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants