-
Notifications
You must be signed in to change notification settings - Fork 0
element/ak timestamp #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kensternberg-authentik
wants to merge
8
commits into
main
Choose a base branch
from
element/ak-timestamp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* main: (53 commits) Fixed typo in css. Added comments to the wcc file. This commit revises the WCCSS transpiler, using the regular expression and merge algorithms recommended by the Patternfly 5 React team. Added wccss pass to package.json. Type inference FTW. Needed to put tools build in-line This commit ports the Elements' build tools to Typescript Cleanup. New css build completing. Crawling back to the original starting point, but this time with better tooling. Save point. This commit introduces a dark-mode controller and code. A working dark mode, although with some dubious decisions Build system revised into a more unixy pattern: each script does one thing well. Bump validator from 13.15.15 to 13.15.20 (#10) Bump vite (#9) First stab at the dark-mode controller; it takes orders from the central context, if there is one, but if not, it tries to determine the mode itself by looking at the user's preferences. Revised brand to meet a... more modern standard. npm trusted publisher More hacking. ...
* main: Forgot to run , and now that I have a hook to do it for me, this is making it whiny.
✅ Deploy Preview for authentik-elements-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This commit adds the `timeout` component to our library, with an “elapsed time” indicator. It also includes an event-monitoring decorator that changes in response to changes to media-queries. While in this case we use it to track `prefers-reduced-motion` (which restricts the `elapsed` time interval to a minimum of 60 seconds, since anything less than that is highly animated), it can be used to track any number of CSS queries, such as `display-mode`, `min-width`, and even `device-posture`. `ak-timeout` uses a highly simplified event state mananger for updating the elapsed time. This is a crude metric, with a minimal resolution of 1000 milliseconds, so I avoided advanced techniques like animation frame. Using `setTimeout()` with a “set the next timeout event” instead of `setInterval()` is generally preferred; the precision is lower, but there’s a heck of a lot less machinery, and stopping it is trivially simpler. \# What \# Why \# How \# Designs \# Test Steps \# Other Notes
* main: (64 commits) Accepted suggestion from @GirlBossRush Update vitest.config.js Update src/ak-button/ak-button.component.ts Update src/ak-button/ak-button.template.ts Typos is dumb, part 2. Typos is dumb. Added comment explaining why href is _removed_ from an anchor when the anchor is disabled. Moving source-maps into devDependencies. I hate wresting with type uncertainty. We now provide the types correctly. NPM between the versions is a massive source of headache. Merge weirdness. Rounding out icon tests. Bump vite (#44) Bump storybook from 9.1.8 to 9.1.17 (#47) bump version Fixing the optimization set in vitest, as recommended on Github. Attempting to fix browser version. Another attempt at getting playwright to play nice. Adjusting test parameters. ...
\# What \# Why \# How \# Designs \# Test Steps \# Other Notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple component for displaying the time accurately.