Skip to content

elements: refactor wccss for dark mode #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kensternberg-authentik wants to merge 6 commits into
base: main
Choose a base branch
from
Open

elements: refactor wccss for dark mode #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ddddecd
The interpreter is working again, and this time 'find dark mode' feat…
kensternberg-authentik Jan 30, 2026
2d13fc4
Dark mode is now correctly interpreted by WCCSS.
kensternberg-authentik Feb 2, 2026
f817210
elements: refactor WCCSS preprocesser to handle dark mode better
kensternberg-authentik Feb 2, 2026
6c4bb9f
Pulse for broken package-lock.
kensternberg-authentik Feb 3, 2026
73a5c6a
Pulse for broken package-lock.
kensternberg-authentik Feb 3, 2026
2dc2004
Merge branch 'main' into wccs-for-dark-mode
kensternberg-authentik Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21,543 changes: 21,543 additions & 0 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
"@patternfly/pfe-core": "^5.0.3",
"date-fns": "^4.1.0",
"lit": "^3.3.1",
"ts-brand": "^0.2.0",
"ts-pattern": "^5.8.0"
},
"devDependencies": {
Expand Down
85 changes: 70 additions & 15 deletions src/ak-button/ak-button.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,6 @@
--button--PaddingRight: var(--pf-v5-c-button--PaddingRight, 1rem);
--button--PaddingBottom: var(--pf-v5-c-button--PaddingBottom, 0.375rem);
--button--PaddingLeft: var(--pf-v5-c-button--PaddingLeft, 1rem);

/* FontFamily and fallback added manually */
--button-_FontFamily--fallback: redhattext, helvetica, arial, sans-serif;
--button--FontFamily: var(--pf-v5-c-button--FontFamily, var(--button-_FontFamily--fallback));
--button--LineHeight: var(--pf-v5-c-button--LineHeight, 1.5);
--button--FontWeight: var(--pf-v5-c-button--FontWeight, 400);
--button--FontSize: var(--pf-v5-c-button--FontSize, 1rem);
Expand Down Expand Up @@ -399,10 +395,6 @@
--pf-v5-c-button--m-link--m-display-lg--FontSize,
1.125rem
);
--button--m-narrow--PaddingTop: var(--pf-v5-c-button--m-narrow--PaddingTop, 0.375rem);
--button--m-narrow--PaddingRight: var(--pf-v5-c-button--m-narrow--PaddingRight, 0.5);
--button--m-narrow--PaddingBottom: var(--pf-v5-c-button--m-narrow--PaddingBottom, 0.375rem);
--button--m-narrow--PaddingLeft: var(--pf-v5-c-button--m-narrow--PaddingLeft, 0.5);
--button__icon--m-start--MarginRight: var(
--pf-v5-c-button__icon--m-start--MarginRight,
0.25rem
Expand Down Expand Up @@ -464,16 +456,20 @@

position: relative;
display: inline-block;

--button-_FontFamily--fallback: redhattext, helvetica, arial, sans-serif;
--button--FontFamily: var(--pf-v5-c-button--FontFamily, var(--button-_FontFamily--fallback));
--button--m-narrow--PaddingTop: var(--pf-v5-c-button--m-narrow--PaddingTop, 0.375rem);
--button--m-narrow--PaddingRight: var(--pf-v5-c-button--m-narrow--PaddingRight, 0.5);
--button--m-narrow--PaddingBottom: var(--pf-v5-c-button--m-narrow--PaddingBottom, 0.375rem);
--button--m-narrow--PaddingLeft: var(--pf-v5-c-button--m-narrow--PaddingLeft, 0.5);
}

[part="button"] {
padding-block-start: var(--button--PaddingTop);
padding-block-end: var(--button--PaddingBottom);
padding-inline-start: var(--button--PaddingLeft);
padding-inline-end: var(--button--PaddingRight);

/* font-family added manually */
font-family: var(--button--FontFamily);
font-size: var(--button--FontSize);
font-weight: var(--button--FontWeight);
line-height: var(--button--LineHeight);
Expand All @@ -483,6 +479,7 @@
border: 0;
border-radius: var(--button--BorderRadius);
position: relative;
font-family: var(--button--FontFamily);
}

[part="button"]::after {
Expand Down Expand Up @@ -549,17 +546,17 @@
--button--FontSize: var(--button--m-small--FontSize);
}

:host([size="sm"]) {
--button--FontSize: var(--button--m-small--FontSize);
}

:host([narrow]) {
--button--PaddingTop: var(--button--m-narrow--PaddingTop);
--button--PaddingRight: var(--button--m-narrow--PaddingRight);
--button--PaddingBottom: var(--button--m-narrow--PaddingBottom);
--button--PaddingLeft: var(--button--m-narrow--PaddingLeft);
}

:host([size="sm"]) {
--button--FontSize: var(--button--m-small--FontSize);
}

:host([size="lg"]) {
--button--PaddingTop: var(--button--m-display-lg--PaddingTop);
--button--PaddingRight: var(--button--m-display-lg--PaddingRight);
Expand Down Expand Up @@ -834,6 +831,64 @@
margin-inline-start: var(--button__icon--m-end--MarginLeft);
}

:host([theme="dark"]) {
--button--disabled--Color: var(--pf-v5-global--disabled-color--300);
--button--m-primary--BackgroundColor: var(--pf-v5-global--primary-color--300);
--button--m-primary--Color: var(--pf-v5-global--primary-color--400);
--button--m-tertiary--after--BorderColor: var(--pf-v5-global--BorderColor--100);
--button--m-tertiary--Color: var(--pf-v5-global--palette--black-100);
--button--m-tertiary--hover--after--BorderColor: var(--pf-v5-global--BorderColor--100);
--button--m-tertiary--hover--Color: var(--pf-v5-global--palette--black-100);
--button--m-tertiary--focus--after--BorderColor: var(--pf-v5-global--BorderColor--100);
--button--m-tertiary--focus--Color: var(--pf-v5-global--palette--black-100);
--button--m-tertiary--active--after--BorderColor: var(--pf-v5-global--BorderColor--100);
--button--m-tertiary--active--Color: var(--pf-v5-global--palette--black-100);
--button--m-warning--Color: var(--pf-v5-global--palette--black-900);
--button--m-warning--hover--Color: var(--pf-v5-global--palette--black-900);
--button--m-warning--focus--Color: var(--pf-v5-global--palette--black-900);
--button--m-warning--active--Color: var(--pf-v5-global--palette--black-900);
--button--m-warning--hover--BackgroundColor: var(--pf-v5-global--warning-color--200);
--button--m-warning--focus--BackgroundColor: var(--pf-v5-global--warning-color--200);
--button--m-warning--active--BackgroundColor: var(--pf-v5-global--warning-color--200);
--button--m-danger--Color: var(--pf-v5-global--palette--black-900);
--button--m-danger--hover--Color: var(--pf-v5-global--palette--black-900);
--button--m-danger--focus--Color: var(--pf-v5-global--palette--black-900);
--button--m-danger--active--Color: var(--pf-v5-global--palette--black-900);
--button--m-link--disabled--Color: var(--pf-v5-global--disabled-color--100);
--button--m-control--BackgroundColor: var(--pf-v5-global--BackgroundColor--400);
--button--m-control--hover--BackgroundColor: var(--pf-v5-global--BackgroundColor--400);
--button--m-control--active--BackgroundColor: var(--pf-v5-global--BackgroundColor--400);
--button--m-control--focus--BackgroundColor: var(--pf-v5-global--BackgroundColor--400);
--button--m-control--m-expanded--BackgroundColor: var(--pf-v5-global--BackgroundColor--400);
--button--m-control--after--BorderTopColor: transparent;
--button--m-control--after--BorderRightColor: transparent;
--button--m-control--after--BorderBottomColor: var(--pf-v5-global--BorderColor--400);
--button--m-control--after--BorderLeftColor: transparent;
--button--m-control--hover--after--BorderBottomColor: var(--pf-v5-global--primary-color--100);
--button--m-control--active--after--BorderBottomColor: var(--pf-v5-global--primary-color--100);
--button--m-control--focus--after--BorderBottomColor: var(--pf-v5-global--primary-color--100);
--button--m-control--m-expanded--after--BorderBottomColor: var(
--pf-v5-global--primary-color--100
);
--button--m-control--disabled--BackgroundColor: var(--pf-v5-global--disabled-color--200);
--button--m-primary__c-badge--BorderColor: var(--pf-v5-global--Color--100);
}

:host([theme="dark"][variant="control"][disabled]) #main::after {
border: 0;
border-block-end: var(--pf-v5-global--BorderWidth--sm) solid
var(--pf-v5-global--palette--black-700);
}

:host:disabled {
color: var(--button--disabled--Color);
background-color: var(--button--disabled--BackgroundColor);
}

:host:disabled #main::after {
border-color: var(--button--disabled--after--BorderColor);
}

:host([variant="link"]:not[inline]):hover #main {
--button--m-link--Color: var(--button--m-link--hover--Color);
--button--m-link--BackgroundColor: var(--button--m-link--hover--BackgroundColor);
Expand Down
7 changes: 0 additions & 7 deletions src/ak-button/ak-button.root.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
--pf-v5-c-button--PaddingRight: var(--pf-v5-global--spacer--md);
--pf-v5-c-button--PaddingBottom: var(--pf-v5-global--spacer--form-element);
--pf-v5-c-button--PaddingLeft: var(--pf-v5-global--spacer--md);
--pf-v5-c-button--FontFamily: var(--pf-v5-global--FontFamily--text);
--pf-v5-c-button--LineHeight: var(--pf-v5-global--LineHeight--md);
--pf-v5-c-button--FontWeight: var(--pf-v5-global--FontWeight--normal);
--pf-v5-c-button--FontSize: var(--pf-v5-global--FontSize--md);
Expand Down Expand Up @@ -179,10 +178,6 @@
--pf-v5-global--active-color--100
);
--pf-v5-c-button--m-small--FontSize: var(--pf-v5-global--FontSize--sm);
--pf-v5-c-button--m-narrow--PaddingTop: var(--pf-v5-global--spacer--form-element);
--pf-v5-c-button--m-narrow--PaddingRight: var(--pf-v5-global--spacer--sm);
--pf-v5-c-button--m-narrow--PaddingBottom: var(--pf-v5-global--spacer--form-element);
--pf-v5-c-button--m-narrow--PaddingLeft: var(--pf-v5-global--spacer--sm);
--pf-v5-c-button--m-display-lg--PaddingTop: var(--pf-v5-global--spacer--md);
--pf-v5-c-button--m-display-lg--PaddingRight: var(--pf-v5-global--spacer--xl);
--pf-v5-c-button--m-display-lg--PaddingBottom: var(--pf-v5-global--spacer--md);
Expand Down Expand Up @@ -221,8 +216,6 @@
--pf-v5-c-button--m-primary__c-badge--BorderWidth: var(--pf-v5-global--BorderWidth--sm);
}

/* OVERRIDDEN Because WCC doesn't quite understand dark mode yet */

.pf-v5-theme-dark,
html[theme="dark"],
html[data-theme="dark"] {
Expand Down
20 changes: 20 additions & 0 deletions src/ak-button/ak-button.overridden.yaml → src/ak-button/ak-button.wcc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,17 @@ host:
":host":
$from: $base
$include: position, display
--button-_FontFamily--fallback: redhattext, helvetica, arial, sans-serif
--button--FontFamily: var(--pf-v5-c-button--FontFamily, var(--button-_FontFamily--fallback))
--button--m-narrow--PaddingTop: var(--pf-v5-c-button--m-narrow--PaddingTop, 0.375rem)
--button--m-narrow--PaddingRight: var(--pf-v5-c-button--m-narrow--PaddingRight, 0.5)
--button--m-narrow--PaddingBottom: var(--pf-v5-c-button--m-narrow--PaddingBottom, 0.375rem)
--button--m-narrow--PaddingLeft: var(--pf-v5-c-button--m-narrow--PaddingLeft, 0.5)
'[part="button"]':
$from: $base
$exclude: /^--/, position, display
position: relative;
"font-family": "var(--button--FontFamily)"
'[part="button"]::after':
$from: "::after"
'[part="anchor"]':
Expand All @@ -24,6 +31,11 @@ host:
$from: /\.pf-m-(active|small|block)/
':host([size="sm"])':
$from: /\.pf-m-small/
":host([narrow])":
"--button--PaddingTop": "var(--button--m-narrow--PaddingTop)"
"--button--PaddingRight": "var(--button--m-narrow--PaddingRight)"
"--button--PaddingBottom": "var(--button--m-narrow--PaddingBottom)"
"--button--PaddingLeft": "var(--button--m-narrow--PaddingLeft)"
':host([size="lg"])':
$from: /\.pf-m-(primary|secondary|tertiary|link)\.pf-m-display-lg/
':host([variant="\1"]) #main':
Expand Down Expand Up @@ -81,3 +93,11 @@ host:
$from: /\.pf-m-link\.pf-m-inline/
':host([variant="\2"][severity="\1"]) #main':
$from: /\.pf-m-(danger)\.pf-m-(link)/
":is(:host:disabled, :host([disabled])) #main":
pointer-events: none
color: var(--button--disabled--Color)
background-color: var(--button--disabled--BackgroundColor)
":is(:host:disabled, :host([disabled])) #main::after":
border-color: var(--button--disabled--after--BorderColor);
':is(:host:disabled, :host([disabled])) [part="anchor"]':
text-decoration: underline;
5 changes: 4 additions & 1 deletion src/ak-empty-state/ak-empty-state.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,10 @@
--empty-state--m-xl__icon--FontSize: var(--pf-v5-c-empty-state--m-xl__icon--FontSize, 6.25rem);
--empty-state__title-text--FontFamily: var(
--pf-v5-c-empty-state__title-text--FontFamily,
'"RedHatDisplay", helvetica, arial, sans-serif'
"RedHatDisplay",
helvetica,
arial,
sans-serif
);
--empty-state__title-text--FontSize: var(--pf-v5-c-empty-state__title-text--FontSize, 1.25rem);
--empty-state__title-text--FontWeight: var(--pf-v5-c-empty-state__title-text--FontWeight, 400);
Expand Down
3 changes: 2 additions & 1 deletion src/ak-icon/ak-icon.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,14 @@
--icon--m-lg__content--FontSize: var(--pf-v5-c-icon--m-lg__content--FontSize, 1.5rem);
--icon--m-xl__content--FontSize: var(--pf-v5-c-icon--m-xl__content--FontSize, 3.375rem);
--icon--m-inline__content--FontSize: var(--pf-v5-c-icon--m-inline__content--FontSize, 1em);

position: relative;
display: inline-flex;
align-items: center;
justify-content: center;
width: var(--icon--Width);
height: var(--icon--Height);

--icon--m-inline__content--Opacity: var(--pf-v5-c-icon--m-inline__content--Opacity, inherit);
}

Expand All @@ -55,7 +57,6 @@
}

[part="content"] {
font-size: var(--icon__content--FontSize);
color: var(--icon__content--Color, inherit);
opacity: var(--icon__content--Opacity, 1);
}
Expand Down
0 src/ak-tooltip/ak-tooltip.overriden.yaml → src/ak-tooltip/ak-tooltip.overridden.yaml
View file
Open in desktop
File renamed without changes.
Loading