element: ak-empty-state #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* element/ak-icon: # ak-icon Icon maybe final Initial check-in for icons. Still needs testing. .
This commit introduces `ak-spinner`, a straightforward throbber component that spins to let people believe something is happening in the background. Has four sizes and can be configured with CSS Custom Properties to change color, speed, direction, and so forth. Matches the Patternfly 5 Spinner component.
* element/ak-spinner: # ak-spinner
* element/ak-icon: Added FontAwesome icon sizes to repetoire. Also: Prettier has opinions.
…does and try again.
This commit introduces `ak-spinner`, a straightforward throbber component that spins to let people believe something is happening in the background. Has four sizes and can be configured with CSS Custom Properties to change color, speed, direction, and so forth. Matches the Patternfly 5 Spinner component.
Signed-off-by: Ken Sternberg <[email protected]>
…y-state * elements/infrastructure-and-brand: add publish workflow Update wdio config. Add missing dep. Make property deletion type friendly. web: Remove effectless await.
* elements/infrastructure-and-brand: add publish workflow Update wdio config. Add missing dep. Make property deletion type friendly. web: Remove effectless await.
… into element/ak-spinner * refs/remotes/origin/element/ak-spinner:
* element/ak-icon: Removing unneeded references. Added FontAwesome icon sizes to repetoire. Also: Prettier has opinions. # ak-icon Icon maybe final Initial check-in for icons. Still needs testing. .
* element/ak-icon: rem, not em, for the pseudo-patternfly icon sizes derivef from fontawesome. Otherwise, the multiplicative effect is... dramatic. Icons as big as your monitor.
* element/ak-icon: rem, not em, for the pseudo-patternfly icon sizes derivef from fontawesome. Otherwise, the multiplicative effect is... dramatic. Icons as big as your monitor. Removing unneeded references.
* element/ak-spinner: # ak-spinner
* element/ak-spinner: Added types.
* element/ak-icon: Prettier still has opinions. Added types to make Teffen happy.
* element/ak-spinner: Prettier has opinions.
kensternberg-authentik
changed the base branch from
main
to
elements/infrastructure-and-brand
* elements/infrastructure-and-brand: Prettier has opinions. Update wdio config. Add missing dep. Make property deletion type friendly. web: Remove effectless await. # Authentik Elements
* element/ak-icon: Prettier has opinions. Update wdio config. Add missing dep. Make property deletion type friendly. web: Remove effectless await. # Authentik Elements
kensternberg-authentik
changed the base branch from
elements/infrastructure-and-brand
to
element/ak-spinner
* element/ak-icon: Prettier's opinions sometimes suck. Prettier still has opinions. Added types to make Teffen happy.
kensternberg-authentik
changed the base branch from
element/ak-spinner
to
main
* main: Forgot to run , and now that I have a hook to do it for me, this is making it whiny.
# What While testing, I discovered that the `disabled` feature was not working as expected. The visuals weren’t being applied correctly, which required some CSS work to correct. This also fixed the issue where the pointer events weren’t being disabled at the same time. There were two issues: the concrete controls were being applied to the wrong component, and the CSS cascade was being read in the wrong order. `disabled` takes priority over virtually everything else, so it has to go at the bottom of the CSS field. After that, I applied [the ARIA rules for disabled links](https://www.w3.org/TR/html-aria/#example-communicate-a-disabled-link-with-aria), which specifies that “to communicate a link as ‘disabled,’ remove the `href` attribute and style accordingly.” That, in turn, caused the underline to go away, which was not desired, so when the displayed part is a “disabled anchor,” I added CSS to force the underline to return. I have added a story to show that the disabled button and disabled link work as expected.
Signed-off-by: Ken Sternberg <[email protected]>
…e anchor is disabled.
* experiment/playwright: (60 commits) Typos is dumb, part 2. Typos is dumb. Added comment explaining why href is _removed_ from an anchor when the anchor is disabled. Moving source-maps into devDependencies. I hate wresting with type uncertainty. We now provide the types correctly. NPM between the versions is a massive source of headache. Merge weirdness. Rounding out icon tests. Bump vite (#44) Bump storybook from 9.1.8 to 9.1.17 (#47) bump version Fixing the optimization set in vitest, as recommended on Github. Attempting to fix browser version. Another attempt at getting playwright to play nice. Adjusting test parameters. Vitest test. Intermediate commit. elements: fix disabled visuals on button Added comment explaining why the initial `attachToAnchor` is run in a late animation frame after `connectedCallback()` ...
* main: (41 commits) Added comment explaining why the initial `attachToAnchor` is run in a late animation frame after `connectedCallback()` admin: adjustments found during integration Removed default border on dialog for tooltip. We'll manage that ourselves, using Patternfly's layout. Continuing to adjust for dark mode, with additions for pulling fonts past the shadowDOM. re-arrange the CSS to better support dark mode. Merge mangling. Something got lost in the merge. Update .gitignore Adopted many of the suggestions from @GirlBossRush Handling focus grabbing. Update src/ak-tooltip/ak-tooltip.component.ts Update src/ak-tooltip/ak-tooltip.component.ts Update src/ak-tooltip/ak-tooltip-state-machine.ts Not sure how that all got re-arranged like that. elements: lintpicking Added types to the state machine. element: ak-tooltip Bump glob (#36) Bump js-yaml from 3.14.1 to 3.14.2 (#33) Bump validator from 13.15.15 to 13.15.23 (#40) ...
* element/ak-spinner: Typos is dumb, part 2. Typos is dumb. Added comment explaining why href is _removed_ from an anchor when the anchor is disabled. Moving source-maps into devDependencies. I hate wresting with type uncertainty. We now provide the types correctly. NPM between the versions is a massive source of headache. Merge weirdness. Rounding out icon tests. Bump vite (#44) Bump storybook from 9.1.8 to 9.1.17 (#47) bump version Fixing the optimization set in vitest, as recommended on Github. Attempting to fix browser version. Another attempt at getting playwright to play nice. Adjusting test parameters. Vitest test. Intermediate commit. elements: fix disabled visuals on button Spinner now has root and local definitions.
* element/ak-spinner: Not sure how this got lost.
✅ Deploy Preview for authentik-elements-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
* element/ak-spinner: OptimizeDeps is hard to get right, apparently. Added lit/localize to the optimizeDeps collection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ak-empty-list
The Empty List, now as a web component!
It has a lot of slots for the icon, the title, a subtitle, footer and action bars.