Merged
Conversation
* element/ak-icon: # ak-icon Icon maybe final Initial check-in for icons. Still needs testing. .
* element/ak-spinner: # ak-spinner
* element/ak-icon: Added FontAwesome icon sizes to repetoire. Also: Prettier has opinions.
…does and try again.
…y-state * elements/infrastructure-and-brand: add publish workflow Update wdio config. Add missing dep. Make property deletion type friendly. web: Remove effectless await.
* element/ak-icon: rem, not em, for the pseudo-patternfly icon sizes derivef from fontawesome. Otherwise, the multiplicative effect is... dramatic. Icons as big as your monitor. Removing unneeded references.
* element/ak-spinner: # ak-spinner
* element/ak-spinner: Added types.
* element/ak-icon: Prettier still has opinions. Added types to make Teffen happy.
* element/ak-spinner: Prettier has opinions.
kensternberg-authentik
changed the base branch from
main
to
elements/infrastructure-and-brand
* element/ak-icon: Prettier has opinions. Update wdio config. Add missing dep. Make property deletion type friendly. web: Remove effectless await. # Authentik Elements
kensternberg-authentik
changed the base branch from
elements/infrastructure-and-brand
to
element/ak-spinner
…isconnects between what we did in 4 and what we want to do in 5. This brings us to parity with 4, but uses 5's classes.
…ate' into element/ak-empty-state * refs/remotes/origin/element/ak-empty-state: Prettier's opinions sometimes suck.
* element/ak-icon: Prettier has opinions. Added some docs. Added notes and fixed a small bug in the preferred 'display' Prettier has opinions.
* element/ak-spinner: Prettier has opinions. Got the function name wrong. Having a custom register broke some typechecking. Added documentation.
…ents, not a validation step, in keeping with the ADR _Don't use JavaScript to maintain CSS_
* element/ak-icon: Linting The Patternfly helper continue. Not using the template for one-liners, and needed extra poking to get patternfly showing up. Fat-fingered and deleted a crucial expression in icon tests. Fixed! Updating with linty fixes.
* element/ak-spinner: Lintpicking!
* main: (21 commits) This commit revises the WCCSS transpiler, using the regular expression and merge algorithms recommended by the Patternfly 5 React team. Added wccss pass to package.json. Type inference FTW. Needed to put tools build in-line This commit ports the Elements' build tools to Typescript Cleanup. New css build completing. Crawling back to the original starting point, but this time with better tooling. Save point. This commit introduces a dark-mode controller and code. A working dark mode, although with some dubious decisions Build system revised into a more unixy pattern: each script does one thing well. Bump validator from 13.15.15 to 13.15.20 (#10) Bump vite (#9) First stab at the dark-mode controller; it takes orders from the central context, if there is one, but if not, it tries to determine the mode itself by looking at the user's preferences. Revised brand to meet a... more modern standard. npm trusted publisher More hacking. Hacking for FA fonts. add storybook build ...
…omer customization.
* main: Forgot to run , and now that I have a hook to do it for me, this is making it whiny. Fixed typo in css. Added comments to the wcc file. element: ak-skip-to-content Implementing Teffen's skip-to-content. In progress Buttons integrated.
\# What \# Why \# How \# Designs \# Test Steps \# Other Notes
kensternberg-authentik
changed the base branch from
element/ak-spinner
to
main
* main: (41 commits) Added comment explaining why the initial `attachToAnchor` is run in a late animation frame after `connectedCallback()` admin: adjustments found during integration Removed default border on dialog for tooltip. We'll manage that ourselves, using Patternfly's layout. Continuing to adjust for dark mode, with additions for pulling fonts past the shadowDOM. re-arrange the CSS to better support dark mode. Merge mangling. Something got lost in the merge. Update .gitignore Adopted many of the suggestions from @GirlBossRush Handling focus grabbing. Update src/ak-tooltip/ak-tooltip.component.ts Update src/ak-tooltip/ak-tooltip.component.ts Update src/ak-tooltip/ak-tooltip-state-machine.ts Not sure how that all got re-arranged like that. elements: lintpicking Added types to the state machine. element: ak-tooltip Bump glob (#36) Bump js-yaml from 3.14.1 to 3.14.2 (#33) Bump validator from 13.15.15 to 13.15.23 (#40) ...
* element/ak-spinner: Typos is dumb, part 2. Typos is dumb. Added comment explaining why href is _removed_ from an anchor when the anchor is disabled. Moving source-maps into devDependencies. I hate wresting with type uncertainty. We now provide the types correctly. NPM between the versions is a massive source of headache. Merge weirdness. Rounding out icon tests. Bump vite (#44) Bump storybook from 9.1.8 to 9.1.17 (#47) bump version Fixing the optimization set in vitest, as recommended on Github. Attempting to fix browser version. Another attempt at getting playwright to play nice. Adjusting test parameters. Vitest test. Intermediate commit. elements: fix disabled visuals on button Spinner now has root and local definitions.
* element/ak-spinner: Not sure how this got lost.
✅ Deploy Preview for authentik-elements-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
* element/ak-spinner: OptimizeDeps is hard to get right, apparently. Added lit/localize to the optimizeDeps collection.
* element/ak-spinner: Accepted suggestion from @GirlBossRush Update vitest.config.js Update src/ak-button/ak-button.component.ts Update src/ak-button/ak-button.template.ts
# What This commit addresses a number of small DX problems that were getting in the way of a decent build-out. - Removed all the Element Interface definitions; they weren’t adding anything to the value of the component. The Builders all use the Class definitions anyway. - Made the builder Props consistent. Some had an `Ak` prefix, some didn’t. I’ve gone with “no Ak prefix” on types being imported for builders. - Added missing t-shirt sizes, even when they’re defaults. - Changed the names of some attributes to be more “positive” about what they mean: “no-loading-message” -\> “spinner-only”; “no-icon” -\> “text-only”; “no-arrow” -\> “hide-arrow”. - Removes `reflect` where it’s not needed. Where it is necessary to trigger CSS effects when the value is dynamically changed (however unlikely that may be), I have added comments to say why reflection is required. - Fix the issue in the Empty State builder where it was generating unneeded slotted divs for TemplateResults. - Removed the `attribute` setting from Tooltip.target; it’s an Object, and cannot have an `attribute` key.
* main: Documentation update
* element/ak-spinner: Last-minute changes lead to last-minute bugs.
# What - Removes the unused Interface declaration - Harmonizes the sizes: Component, Template, and Builder all agree “large” is the default - Change ‘no-icon’ boolean attribute to ‘text-only’ (HTML tries to “use positive names for attributes”) - Fixes some of the rendering issues in the builder: - Fix “secondary-actions” slot name - Use `<h2>` with string-only title - Use `<p>` with string-only body - Use `<ak-icon>` with string-only icon - Remove unloved console.log() :-) - Add story to Storybook “builder” section to show string-only usage
BeryJu
approved these changes
Jan 14, 2026
github-project-automation
bot
moved this from Needs review
to In Progress
in authentik Core
* main: Not sure why tests are failing. Trying test fix. element/ak-timestamp: consistency pass and final check element/ak-divider: consistency check and test update elements: structural issues Applies the new vitest suite to ak-timestamp. element: ak-timeout And divider is now themable and dark-mode capable. Updating for release. Fixed some lint. Lint and prettier pass. Found a few disconnects, fixed them. Adding the timestamp component. Remove custom registration, run prettier, remove old CSS. Ported from foundation, and heavily revised. An analysis of the CSS revealed it was far more complicated than it needed to be; using the Patternfly trick of communicating embedded state through scoped variables names turned out to be much more coherent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ak-empty-state
The Empty State, now as a web component!
It has a lot of slots for the icon, the title, a subtitle, footer and action bars.