Skip to content

Make lines in warning output clickable in VS Code #1769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Make lines in warning output clickable in VS Code #1769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0d72df0
replaced colons by dots in error report range notation
Robotechnic Jun 26, 2025
8db2825
fixed the test suite
Robotechnic Jun 26, 2025
a2977da
fixed cram tests
Robotechnic Jun 26, 2025
e151423
fixed cram tests
Robotechnic Jun 26, 2025
1913c4c
fixed cram tests
Robotechnic Jun 26, 2025
509f356
fixed cram tests
Robotechnic Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/update_suite.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ def collect_warnings
@evals = $2
end
if l =~ /\[Termination\]/ then warnings[-1] = "nonterm" end # Get Termination warning
next unless l =~ /(.*)\(.*?\:(\d+)(?:\:\d+)?(?:-(?:\d+)(?:\:\d+)?)?\)/
next unless l =~ /(.*)\(.*?\:(\d+)(?:\.\d+)?(?:-(?:\d+)(?:\.\d+)?)?\)/
obj,i = $1,$2.to_i

ranking = ["other", "warn", "goto", "fundec", "loop", "term", "nonterm", "race", "norace", "deadlock", "nodeadlock", "success", "fail", "unknown"]
Expand Down
4 changes: 2 additions & 2 deletions src/common/util/cilType.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,14 @@ struct
(* TODO: add special output for locUnknown *)
x.file ^ ":" ^ string_of_int x.line ^ (
if x.column >= 0 then
":" ^ string_of_int x.column
"." ^ string_of_int x.column
else
""
) ^ (
if x.endByte >= 0 then
"-" ^ string_of_int x.endLine ^ (
if x.endColumn >= 0 then
":" ^ string_of_int x.endColumn
"." ^ string_of_int x.endColumn
else
""
)
Expand Down
144 changes: 72 additions & 72 deletions tests/regression/00-sanity/01-assert.t
View file
Open in desktop

Large diffs are not rendered by default.

18 changes: 9 additions & 9 deletions tests/regression/00-sanity/19-if-0.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,27 +8,27 @@
│ (body)
▼
┌────────────────────────────────┐ ┌────────────────────────────────┐
│ 19-if-0.c:15:9-15:27 │ │ 19-if-0.c:9:5-16:5 │
│ (19-if-0.c:15:9-15:27) │ │ (19-if-0.c:9:9-9:10) │
│ YAML loc: 19-if-0.c:15:9-15:27 │ Neg(0) │ YAML loc: 19-if-0.c:9:5-16:5 │
│ 19-if-0.c:15.9-15.27 │ │ 19-if-0.c:9.5-16.5 │
│ (19-if-0.c:15.9-15.27) │ │ (19-if-0.c:9.9-9.10) │
│ YAML loc: 19-if-0.c:15.9-15.27 │ Neg(0) │ YAML loc: 19-if-0.c:9.5-16.5 │
│ server: true │ ◀──────────────────── │ server: true │
└────────────────────────────────┘ └────────────────────────────────┘
│ │
│ │ Pos(0)
│ ▼
│ ┌────────────────────────────────┐
│ │ 19-if-0.c:11:9-11:16 │
│ │ (19-if-0.c:11:9-11:16) │
│ │ YAML loc: 19-if-0.c:11:9-11:16 │
│ │ 19-if-0.c:11.9-11.16 │
│ │ (19-if-0.c:11.9-11.16) │
│ │ YAML loc: 19-if-0.c:11.9-11.16 │
│ │ server: true │
│ └────────────────────────────────┘
│ │
│ │ stuff()
│ ▼
│ ┌────────────────────────────────┐
│ │ 19-if-0.c:17:5-17:13 │
│ │ (19-if-0.c:17:12-17:13) │
│ __goblint_check(1) │ YAML loc: 19-if-0.c:17:5-17:13 │
│ │ 19-if-0.c:17.5-17.13 │
│ │ (19-if-0.c:17.12-17.13) │
│ __goblint_check(1) │ YAML loc: 19-if-0.c:17.5-17.13 │
└────────────────────────────────────────────────────▶ │ server: true │
└────────────────────────────────┘
│
Expand Down
20 changes: 10 additions & 10 deletions tests/regression/00-sanity/20-if-0-realnode.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,29 +8,29 @@
│ (body)
▼
┌─────────────────────────────────────────┐
│ 20-if-0-realnode.c:10:5-16:5 │
│ (20-if-0-realnode.c:10:9-10:10) │
│ [20-if-0-realnode.c:9:5-10:5 │ Neg(0)
│ 20-if-0-realnode.c:10.5-16.5 │
│ (20-if-0-realnode.c:10.9-10.10) │
│ [20-if-0-realnode.c:9.5-10.5 │ Neg(0)
│ (unknown)] │ ─────────┐
│ YAML loc: 20-if-0-realnode.c:10:5-16:5 │ │
│ YAML loc: 20-if-0-realnode.c:10.5-16.5 │ │
│ server: true │ ◀────────┘
└─────────────────────────────────────────┘
│
│ Pos(0)
▼
┌─────────────────────────────────────────┐
│ 20-if-0-realnode.c:12:9-12:16 │
│ (20-if-0-realnode.c:12:9-12:16) │
│ YAML loc: 20-if-0-realnode.c:12:9-12:16 │
│ 20-if-0-realnode.c:12.9-12.16 │
│ (20-if-0-realnode.c:12.9-12.16) │
│ YAML loc: 20-if-0-realnode.c:12.9-12.16 │
│ server: true │
└─────────────────────────────────────────┘
│
│ stuff()
▼
┌─────────────────────────────────────────┐
│ 20-if-0-realnode.c:17:5-17:13 │
│ (20-if-0-realnode.c:17:12-17:13) │
│ YAML loc: 20-if-0-realnode.c:17:5-17:13 │
│ 20-if-0-realnode.c:17.5-17.13 │
│ (20-if-0-realnode.c:17.12-17.13) │
│ YAML loc: 20-if-0-realnode.c:17.5-17.13 │
│ server: true │
└─────────────────────────────────────────┘
│
Expand Down
Loading
Loading