Use access events in useAfterFree analysis #1864
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of (incorrectly) duplicating the logic of what's being accessed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is on top of #1862 just to test on those regression test as well.
This is a quick attempt at fixing my long-time frustration with the useAfterFree analysis (there are also others).
We already have a very established access analysis which emits events for everything that is being accessed. Since it forms the basis of race analysis, it has gone through a lot of testing and iterations to make it correct.
So, the useAfterFree analysis should just use these events instead of (incorrectly) duplicating the logic of what's being accessed.
It seems to pass all of our regression tests, but appears to avoid the Juliet imprecision of #1861.
TODO