Conversation
Member
|
@jerhard or @stilscher, could you have a look? You guys know more about the intricacies of the solver. |
jerhard
requested changes
Jan 10, 2023
jerhard
approved these changes
Jan 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the constraint system has a
boxfunction, which is always defined to just be warrowing, and at one point that is passed on via theboxargument ofsolvein solvers.This is redundant because solvers then have access to
boxin two different ways. Also the fixed box doesn't need to be carried around everywhere.Therefore, this removes
boxboth from the constraint system and solver argument.SLR is the only solver that in some variation overrides
boxto just widen or narrow, making the argument also irrelevant. Since the choice ofboxis such a solver-specific thing, it makes the most sense to just do it directly in the solver in a way that's supported by the solver.