Add __loop_condition labels before syntactic loop conditions
#197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing while_continue labels (which aren't used for anything) are always at the beginning of loop body, which would be wrong for do-while loops. The __Cont labels (which are actually used for continue-s) are always at the end of loop body, which would be wrong for for loops.
1 task
Member
|
I think we should make this configurable, the CIL AST now is polluted with lots of strange SV-COMP related things, which I may not want to have if I am, e.g., using CIL primarily as a merger. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing
while_continuelabels (which aren't used for anything) are always at the beginning of loop body, which would be wrong fordo-whileloops.The
__Contlabels (which are actually used forcontinue-s) are always at the end of loop body, which would be wrong forforloops.So this is needed to mark the location before evaluating the loop condition, which is needed to fix goblint/analyzer#1736.