You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jul 12, 2025. It is now read-only.
For go's format rules, I think if we continues using "Merge pull request" button to merge PRs, it will make the master's codes been un-formatted again. I think we should using "Rebase" method to submit PRs, and rebase every PR before submit to avoid this.
I saw goby is using go module and the old vendor folder still here, and having code not been formatted, so just removed this folder, I don't know whether this is suitable?
I understand the intention behind this change, but I don't feel the need to format all the code, especially not the vendor files. We use vendor because unlike normal applications, Goby's dependencies should be as steady as possible. And I want to minimize the risk that if a dependency is removed from the source, we won't be able to build our source code again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw current codes have not been formatted yet, so just added a travis ci step to check it, and I think this should work since this PR is failed now: https://travis-ci.org/github/goby-lang/goby/builds/738725791
I'll add another commit to format the codes and let CI pass again.