Skip to content

Return existing builder from PathBuilder.Root() instead of creating a new one. #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tobb10001 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Return existing builder from PathBuilder.Root() instead of creating a new one. #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba40289
add test for path builder without method chainging
tobb10001 Jan 15, 2024
716b6f3
fix PathBuilder.Root() for non-chained method calls
tobb10001 Jan 15, 2024
fdcc8ba
add comment to reference corresponding PR
tobb10001 Jan 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion path.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,9 @@ type PathBuilder struct {
// Root add '$' to current path.
func (b *PathBuilder) Root() *PathBuilder {
root := newRootNode()
return &PathBuilder{root: root, node: root}
b.root = root
b.node = root
return b
}

// IndexAll add '[*]' to current path.
Expand Down
17 changes: 17 additions & 0 deletions path_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,23 @@ func TestPathBuilder(t *testing.T) {
}
}

func TestPathBuilderNoChain(t *testing.T) {
// See PR #420.
builder := yaml.PathBuilder{}
builder.Root()
builder.Child("a")
builder.Child("b")
builder.Index(0)
path := builder.Build()

expected := `$.a.b[0]`
got := path.String()

if expected != got {
t.Fatalf("failed to build path. expected:[%q] but got:[%q]", expected, got)
}
}

func TestPath(t *testing.T) {
yml := `
store:
Expand Down