Open
Conversation
… go official library for encoding detection in place of it.
WGH-
reviewed
Oct 16, 2023
Comment on lines
+89
to
+90
| _, nameOfEncoding, _ := charset.DetermineEncoding(r.Body, contentType) //name of charset/encoding | ||
| contentType = "text/plain; charset=" + nameOfEncoding |
Collaborator
There was a problem hiding this comment.
charset.DetermineEncoding returns the detected encoding, so I think this entire function can be greatly simplified and largely replaced with rougly this:
enc, _, certain := charset.DetermineEncoding(r.Body, contentType)
if !certain && !detectCharset {
return nil
}
var err error
r.Body, err = ioutil.ReadAll(enc.NewDecoder().Reader(bytes.NewReader(r.Body)))
return err
WGH-
reviewed
Oct 16, 2023
WGH-
requested changes
Oct 16, 2023
Collaborator
WGH-
left a comment
There was a problem hiding this comment.
Thanks! This needs a couple of changes, though (see above).
And please clean up your commit history (or I will do it myself before the merge)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connected to issue #777 "HTML encoding is not autodetected properly". I removed the current gocolly encoding detection, which through tests showed to be unreliable when detecting Cyrillic encodings, and in place of it used the built-in function DetermineEncoding from the charset package.