Skip to content

Add support for Bluesky in the social media options#922

Merged
EvanHerman merged 3 commits intogodaddy-wordpress:masterfrom
aaroncampbell:master
Mar 15, 2025
Merged

Add support for Bluesky in the social media options#922
EvanHerman merged 3 commits intogodaddy-wordpress:masterfrom
aaroncampbell:master

Conversation

@aaroncampbell
Copy link
Contributor

@aaroncampbell aaroncampbell commented Mar 12, 2025

No description provided.

@EvanHerman EvanHerman mentioned this pull request Mar 15, 2025
Merged
@EvanHerman EvanHerman self-requested a review March 15, 2025 17:15
EvanHerman
EvanHerman approved these changes Mar 15, 2025
View reviewed changes
Copy link
Contributor

@EvanHerman EvanHerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me. I pushed a small fix for the e2e customizer tests that were failing. Thanks for this contribution 👍

@EvanHerman EvanHerman merged commit df8238b into godaddy-wordpress:master Mar 15, 2025
10 checks passed
@EvanHerman EvanHerman added this to the 1.8.13 milestone Mar 31, 2025
@EvanHerman EvanHerman added the [Type] Enhancement Something new that adds functionality label Mar 31, 2025
@Aymkdn
Copy link

Aymkdn commented Apr 3, 2025 •
edited
Loading

Thanks for publishing these changes!

However, I noticed the Bluesky SVG icon has a width and fill that are defined:

<svg width="568" height="501" viewBox="0 0 568 501" fill="none" xmlns="http://www.w3.org/2000/svg">
<path d="M123.121 33.6637C188.241 82.5526 258.281 181.681 284 234.873C309.719 181.681 379.759 82.5526 444.879 33.6637C491.866 -1.61183 568 -28.9064 568 57.9464C568 75.2916 558.055 203.659 552.222 224.501C531.947 296.954 458.067 315.434 392.347 304.249C507.222 323.8 536.444 388.56 473.333 453.32C353.473 576.312 301.061 422.461 287.631 383.039C285.169 375.812 284.017 372.431 284 375.306C283.983 372.431 282.831 375.812 280.369 383.039C266.939 422.461 214.527 576.312 94.6667 453.32C31.5556 388.56 60.7778 323.8 175.653 304.249C109.933 315.434 36.0535 296.954 15.7778 224.501C9.94525 203.659 0 75.2916 0 57.9464C0 -28.9064 76.1345 -1.61183 123.121 33.6637Z" fill="black"></path>
</svg>

Which is rendering with a very large width, and using a black color.

If we look at another icon (like Github):

<svg role="img" aria-hidden="true" xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24"><path d="M12 0c-6.626 0-12 5.373-12 12 0 5.302 3.438 9.8 8.207 11.387.599.111.793-.261.793-.577v-2.234c-3.338.726-4.033-1.416-4.033-1.416-.546-1.387-1.333-1.756-1.333-1.756-1.089-.745.083-.729.083-.729 1.205.084 1.839 1.237 1.839 1.237 1.07 1.834 2.807 1.304 3.492.997.107-.775.418-1.305.762-1.604-2.665-.305-5.467-1.334-5.467-5.931 0-1.311.469-2.381 1.236-3.221-.124-.303-.535-1.524.117-3.176 0 0 1.008-.322 3.301 1.23.957-.266 1.983-.399 3.003-.404 1.02.005 2.047.138 3.006.404 2.291-1.552 3.297-1.23 3.297-1.23.653 1.653.242 2.874.118 3.176.77.84 1.235 1.911 1.235 3.221 0 4.609-2.807 5.624-5.479 5.921.43.372.823 1.102.823 2.222v3.293c0 .319.192.694.801.576 4.765-1.589 8.199-6.086 8.199-11.386 0-6.627-5.373-12-12-12z"></path></svg>

The width is 24 and no reference to fill.

Then it means we need to modify our CSS to make this icon looks like the other ones (at least for my Wordpress).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EvanHerman EvanHerman EvanHerman approved these changes

Assignees

@aaroncampbell aaroncampbell

Labels

[Type] Enhancement Something new that adds functionality

Projects

None yet

Milestone

1.8.13

Development

Successfully merging this pull request may close these issues.

3 participants

@aaroncampbell @Aymkdn @EvanHerman