Skip to content

Add support for Bluesky in the social media options #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EvanHerman merged 3 commits into from
Mar 15, 2025
Merged

Add support for Bluesky in the social media options #922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3a1f8e
Add support for Bluesky in the social media options
aaroncampbell Mar 12, 2025
554d109
Code alignment fix
aaroncampbell Mar 12, 2025
fa45cd2
Update actions/upload-artifact@v3
EvanHerman Mar 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .dev/assets/shared/images/social/bluesky.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions .dev/tests/cypress/integration/customizer/customizer.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ describe( 'Test the customizer works as intended.', () => {
github: 'https://www.github.com',
tiktok: 'https://www.tiktok.com',
mastodon: 'https://mastodon.social',
bluesky: 'https://bsky.app/',
};

before( () => {
Expand Down
3 changes: 2 additions & 1 deletion .dev/tests/php/test-core.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1017,7 +1017,8 @@ function testGetAvailableSocialIcons() {
'spotify',
'github',
'tiktok',
'mastodon'
'mastodon',
'bluesky',
];

$this->assertEquals( $social_icons, array_keys( Go\Core\get_available_social_icons() ) );
Expand Down
3 changes: 2 additions & 1 deletion .dev/tests/php/test-customizer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1071,7 +1071,8 @@ function test_register_social_controls_social_icon_x_setting_and_controls() {
'youtube',
'github',
'tiktok',
'mastodon'
'mastodon',
'bluesky',
];

foreach ( $networks as $social_network ) {
Expand Down
13 changes: 13 additions & 0 deletions .dev/tests/php/test-template-tags.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1341,6 +1341,19 @@ public function test_social_icons_mastodon() {

}

/**
* Test the post_meta() returns proper data bluesky icon data
*/
public function test_social_icons_bluesky() {

set_theme_mod( 'social_icon_bluesky', 'https://bsky.app/profile/custom' );

$this->expectOutputRegex( '/<a class="social-icons__icon" href="https:\/\/bsky.app\/profile\/custom" aria-label="Open Bluesky in a new tab" rel="noopener noreferrer" target="_blank">/' );

Go\social_icons( [] );

}

/**
* Test the social icons do not render on header-1
*/
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/create-artifact.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
zip -r $ARTIFACT_ZIP $ARTIFACT_PATH

- name: Upload artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ${{ env.ARTIFACT_NAME }}
path: ${{ env.ARTIFACT_ZIP }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/run-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ jobs:

- name: Upload failure video
if: ${{ failure() }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: customizer.spec.js.mp4
path: ./.dev/tests/cypress/videos/**/*.mp4
Expand Down
5 changes: 5 additions & 0 deletions includes/core.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1262,6 +1262,11 @@ function get_available_social_icons() {
'icon' => get_theme_file_path( 'dist/images/social/mastodon.svg' ),
'placeholder' => 'https://mastodon.social/@user',
),
'bluesky' => array(
'label' => esc_html__( 'Bluesky', 'go' ),
'icon' => get_theme_file_path( 'dist/images/social/bluesky.svg' ),
'placeholder' => 'https://bsky.app/profile/user',
),
);

/**
Expand Down
1 change: 1 addition & 0 deletions languages/go.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@
"d3b7c913cd04ebfec0e9ec32cb6fd58c": "GitHub",
"d7a9a3e2a98999afaa77e64983165058": "TikTok",
"675cd6f3e569b77f0bae964e0a8942f2": "Mastodon",
"b86a320e28500179ca4f051bc574520c": "Bluesky",
"e27721c74d54c8f57cc581c680a0143b": "That page can't be found",
"04cc2ca3a963a638a60162312fa1bb72": "Search for: %s",
"795d59a96adcde416d31c5b1b6fae364": "Nothing Found",
Expand Down
Loading