Add a PageHelper class to check for current admin page
#736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nmolham-godaddy
left a comment
nmolham-godaddy
left a comment
There was a problem hiding this comment.
Nice addition, what do you think about this change d0012c2? It makes sense to move the class sanity check into the getWooCommercePageController to avoid repeating that check in future methods
Contributor
Author
You're right -- good call! |
nmolham-godaddy
approved these changes
Feb 20, 2025
Contributor
nmolham-godaddy
left a comment
nmolham-godaddy
left a comment
There was a problem hiding this comment.
QA passed, I just took advantage of this opportunity to include ArrayHelper::get method as well, which made perfect sense in this context 7cff851...1c35f14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a
PageHelperclass with a handy method to check if we're on the WooCommerce analytics page.Release: #734
QA
Before merge