Fixes for loading translations too early #757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agibson-godaddy
changed the title
Contributor
|
With this branch and the dev branch of the Framework, I'm still seeing the |
Contributor
|
Sorry, meant to leave that last comment on the memberships PR. |
…le SV_WC_Plugin::init_hook_deprecator() method.
ajaynes-godaddy
added a commit
that referenced
this pull request
Apr 30, 2025
* Version 5.15.7 * Update versions in coffee files * Fixes for loading translations too early (#757) * Pass entire plugin instance into the deprecator class * Improve the 5.15.7 changelog entry in the SV_WC_Hook_Deprecator constructor. * Changelog language tweaks. * Add a changelog entry for the behavior change in the plugin-overridable SV_WC_Plugin::init_hook_deprecator() method. * Docblock for getPluginName(). --------- Co-authored-by: Andrew Jaynes <[email protected]> * Update a use of @import to @use for future compat with Dart Sass 3.0. * Pot file updates from npm run build. * Add a changelog entry for the the translations fixes. * s/logging/triggering --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Ashley Gibson <[email protected]> Co-authored-by: Ashley Gibson <[email protected]> Co-authored-by: Andrew Jaynes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Release: #755
This is a partial fix (not guaranteed to be 100% complete) to address errors like this:
Release: #755
Details
SV_WC_Hook_Deprecatorhas been updated to accept the entire plugin instance as a parameter instead of just the plugin name. That way we can callget_plugin_name()when actually used instead of inside the constructor.QA
Before merge