fix/767: remove common JS modules from dist #768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agibson-godaddy
approved these changes
May 8, 2025
Contributor
There was a problem hiding this comment.
Thank you so much for this PR! I was able to confirm the fix.
For future reference, here's the info regarding these settings: https://parceljs.org/features/targets/#target-options
agibson-godaddy
merged commit 33d78c7
into
godaddy-wordpress:release/5.15.10
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #767
Adds Parcel config to output browser compatible JS.
Steps
Steps should be in a step => success? format, like below:
npm ci && npm run buildBefore merge